You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix the eslint issues in the test files, add a grunt task or npm script (v4: Move to npm scripts #20332) to transpile the test files, and update the references in index.html. This is obviously more work but would be more of a long term benefit.
I'm open to other ways to please @houndbot-ci when changing JS test files and willing to put in the work 😅
The text was updated successfully, but these errors were encountered:
@maxbeatty just an update on this. Once #21005 merges, Travis will lint tests correctly. Hound is still mad because of houndci/hound#889, but that's more annoying than show-stopping for now.
Closing out given latest comment from @bardiharborow. Holler if this needs to be re-opened to track anything else not already covered in another issue or PR <3.
I've opened a few PRs and each gets lots of comments from @houndci-bot because the JS unit test files do not conform to the ESLint settings. Here are few ways I've considered addressing this:
index.html
. This is obviously more work but would be more of a long term benefit.I'm open to other ways to please @houndbot-ci when changing JS test files and willing to put in the work 😅
The text was updated successfully, but these errors were encountered: