Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4 Migration docs still refer to .has-danger #23802

Closed
exige81 opened this issue Sep 1, 2017 · 2 comments
Closed

v4 Migration docs still refer to .has-danger #23802

exige81 opened this issue Sep 1, 2017 · 2 comments

Comments

@exige81
Copy link
Contributor

exige81 commented Sep 1, 2017

From docs/4.0/migration.md

Forms

  • Moved element resets to the _reboot.scss file.
  • Renamed .control-label to .form-control-label.
  • Renamed .input-lg and .input-sm to .form-control-lg and .form-control-sm, respectively.
  • Dropped .form-group-* classes for simplicity's sake. Use .form-control-* classes instead now.
  • Dropped .help-block and replaced it with .form-text for block-level help text. For inline help text and other flexible options, use utility classes like .text-muted.
  • Dropped .radio-inline and .checkbox-inline.
  • Horizontal forms overhauled:
    • Dropped the .form-horizontal class requirement.
    • .form-group no longer applies styles from the .row via mixin, so .row is now required for horizontal grid layouts (e.g., <div class="form-group row">).
    • Added new .form-control-label class to vertically center labels with .form-controls.
    • Added new .form-row for compact form layouts with the grid classes (swap your .row for a .form-row and go).
  • Added custom forms support (for checkboxes, radios, selects, and file inputs).
  • Added HTML5 form validation support via CSS's :invalid and :valid pseudo-classes.
    - Renamed .has-error to .has-danger.
  • Renamed .form-control-static to .form-control-plaintext.

This was replaced by .is-invalid

@andresgalante
Copy link
Collaborator

Hi @exige81, Do you want to send a PR with this? I can help you if you need a hand 👍

@exige81
Copy link
Contributor Author

exige81 commented Sep 6, 2017

PR to fix this here: #23842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants