Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent gray-dark #24353

Closed
supergibbs opened this issue Oct 12, 2017 · 3 comments
Closed

Inconsistent gray-dark #24353

supergibbs opened this issue Oct 12, 2017 · 3 comments
Labels
docs v4

Comments

@supergibbs
Copy link
Contributor

The color gray-dark is specified in the _variables.scss as gray-800 but in the theming.md doc as gray-900. I'd make a PR but not sure which is right.
@andresgalante
Copy link
Collaborator

Hi @supergibbs

The source of truth should be _variables.scss. If you don't have time to send the PR please let me know and I'll update the documentation.

Thanks a lot!

@supergibbs supergibbs mentioned this issue Oct 12, 2017
Merged
@supergibbs
Copy link
Contributor Author

@andresgalante Thanks for the clarification, fixed that and updated the rest of the colors too

@andresgalante andresgalante mentioned this issue Oct 12, 2017
Closed
@andresgalante andresgalante removed the css label Oct 12, 2017
@andresgalante
Copy link
Collaborator

ups sorry, I've just sent a PR. It seems like patience is not one of my virtues.
Please send yours and I'll close mine. I am sorry @supergibbs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@supergibbs @andresgalante