Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Carousel swipe-able #2468

Closed
ShaggyDude opened this issue Mar 8, 2012 · 26 comments
Closed

Make Carousel swipe-able #2468

ShaggyDude opened this issue Mar 8, 2012 · 26 comments
Labels

Comments

@ShaggyDude
Copy link

Is this a good idea or no?
Or, is there a good library out there that would fill this need?

@ibrent
Copy link

ibrent commented Mar 10, 2012

try swipejs.com
https://github.com/bradbirdsall/Swipe
try the branch for swipe2

@fat
Copy link
Member

fat commented Mar 20, 2012

While i think adding swipe support is awesome, don't think it should be bake into the core of the plugin. Definitely something which should live in a mobile extension. :)

@fat fat closed this as completed Mar 20, 2012
@ibrent
Copy link

ibrent commented Mar 20, 2012

Bummer. I disagree since touch devices are in everyone's pockets and are coming to most screens near you. The amount of touch code is small but adds usable functionality which people will soon expect from modules like sliders etc. I thought that Bootstrap was built for both today and the future.

@fat
Copy link
Member

fat commented Mar 20, 2012

The reason is that swipe is an enhancement (a cool one, but still an enhancement). If carousel didn't work at all, it would be a different story.

@ibrent
Copy link

ibrent commented Mar 20, 2012

OK I understand. It's your ship and you are the captain. And it's a rockin good ship by the way - thank you.

I like Chris' touch carousel addition and would love it as a mobile extension. I also bet you a delicious beverage of your choice that within 9 months you will be adding touch events into the core.

@fat
Copy link
Member

fat commented Mar 20, 2012

well if @pamelafox keeps up the crossfit she might just bully me into it :)

@ibrent
Copy link

ibrent commented Mar 20, 2012

Understood. :D

@andyburke
Copy link

It's a shame this is closed. It would be nice to have this by default. Instead I am looking at having to roll my own with swipe.js or something else. The pull request looks like a really nice addition.

@briznad
Copy link

briznad commented Feb 8, 2013

With the move to Bootstrap 3 and the mobile-first approach, perhaps this is no longer an enhancement, but something that should be baked into the carousel core.

@johannesnagl
Copy link

+1

1 similar comment
@naoufal
Copy link

naoufal commented Feb 18, 2013

+1

@JadH
Copy link

JadH commented Feb 19, 2013

How about having it as an option?
Keep the current one and add the swipe on its own?

@briznad
Copy link

briznad commented Feb 19, 2013

For those wanting an interim fix, the following tutorial (not mine) provides an easy workaround:
http://lazcreative.com/blog/how-to/how-to-adding-swipe-support-to-bootstraps-carousel/

@lukebrowell
Copy link

+1 this is not just needed for mobile, it's for all touch enabled devices, including tablets, and future hybrids like microsoft surface

@kieste
Copy link

kieste commented Apr 12, 2013

+1

1 similar comment
@tector
Copy link

tector commented Apr 12, 2013

+1

@kieste
Copy link

kieste commented Apr 13, 2013

The JQMobile solution doesn't work on my iPhone with current WIP Bootstrap 3 !?
But this one works for me out of the box: http://www.netcu.de/jquery-touchwipe-iphone-ipad-library

$(window).load(function(){
    $("#myCarousel").touchwipe({
        wipeLeft: function() { $("#myCarousel").carousel('next'); },
        wipeRight: function() { $("#myCarousel").carousel('prev'); }
    });
});

@boulox
Copy link
Contributor

boulox commented Apr 13, 2013

@kieste look nice did you give it a shot on android or windows mobile?

@kieste
Copy link

kieste commented Apr 13, 2013

Tested on Galaxy S II with Chrome. Works like a charm.
Had to set "preventDefaultEvents" to false so that vertical page scrolling still works when moving up and down on the carousel.

@marygutz
Copy link

+1

@ghost
Copy link

ghost commented Jun 5, 2013

+1 for adding to the core.

@ghost
Copy link

ghost commented Jul 15, 2013

+1

1 similar comment
@chrisdewar
Copy link

+1

@ixisio
Copy link

ixisio commented Sep 18, 2013

drop in replacement for twbs carousel to enable gestures on touch devices:
https://github.com/ixisio/bootstrap-touch-carousel

have fun,
Cheers

@qasimzahoor-developer
Copy link

i have searched lot but i can not find solution for my website http://www.awaak.com/ , is there any fixation for carousel without including any extra css or js files,

@twbs twbs locked and limited conversation to collaborators May 21, 2015
@juthilo
Copy link
Collaborator

juthilo commented May 21, 2015

Please refer to StackOverflow for additional discussion, as there's nothing to do here on Bootstrap's side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests