Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration document incorrect - table-responsive #26449

Closed
Braunson opened this issue May 3, 2018 · 3 comments
Closed

Migration document incorrect - table-responsive #26449

Braunson opened this issue May 3, 2018 · 3 comments

Comments

@Braunson
Copy link

Braunson commented May 3, 2018

So I'm following the 4.0 migration docs which tell me to:

Responsive tables no longer require a wrapping element. Instead, just put the .table-responsive right on the <table>

Awesome, so I manually replace all 100+ instances where it was wrapped. Now I got to test and this happens.

So should they still be wrapped in 4.x or no? The docs here say to wrap them, the migration here says there's no need anymore

@thatnini
Copy link

thatnini commented May 4, 2018

They should still be wrapped.

Duplicate of #25509

@Braunson
Copy link
Author

Braunson commented May 4, 2018

While it may be a duplicate of a closed ticket, the issue still stands, the PR #25539 which is suppose to remove that line for some reason or another hasn't been applied to the live site.

@ysds
Copy link
Contributor

ysds commented May 4, 2018

v4.0 docs have been outdated.

Please see https://getbootstrap.com/docs/4.1/migration/

@Braunson Braunson closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants