Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.text-monospace / .font-monospace #26619

Closed
ysds opened this issue May 29, 2018 · 5 comments
Closed

.text-monospace / .font-monospace #26619

ysds opened this issue May 29, 2018 · 5 comments
Labels

Comments

@ysds
Copy link
Contributor

ysds commented May 29, 2018

The .text-monospace class name is little confusing. .font-monospace is more appropriate. Is there a plan to change the class name in the future (v5)? Is there a chance to coexist both classes in v4? Thanks.

@sts-ryan-holton
Copy link
Contributor

I'm sure this once was .font-monospace and was changed to .text-monospace in 4.1?

@ysds
Copy link
Contributor Author

ysds commented May 29, 2018

That is a typo #26239. I think that the confusion of the class name caused the typo.

@andresgalante
Copy link
Collaborator

I agree font makes more sense than text for monospace. Names are messed up even in CSS.

A change now would be a breaking change, I'd avoid having 2 classes that do the same on v4, but I'll add this issue to v5 ideas.

@ysds
Copy link
Contributor Author

ysds commented May 30, 2018

@andresgalante OK, thanks. It’s up to you to close this issue or leave as a backlog.

@mdo
Copy link
Member

mdo commented May 30, 2018

Closing for now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants