-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse stopped working after #26630 PR merge i.e in v4.1.2 #26968
Comments
Bug reports must include a live demo of the problem. Per our contributing guidelines, please create a reduced test case via StackBlitz and report back with your link, Bootstrap version, and specific browser and OS details. |
Here is the StackBlitz test case for Boostrap v4.1.2 in which the embed collapse item under Angular's ng-template directive does not works. Angular Version 6.1.0 And here is with Bootstrap v4.1.1 in which the same code works i.e the collapse items work as per desired. Angular Version 6.1.0 |
That's because you use bad For example in your StackBlitz (https://angular-ylnusl.stackblitz.io/) if you try to do : And that's what is done by Bootstrap under the hood, because we changed how we get our DOM elements, before we used jQuery, now we use native methods ( I fixed your code with valid ids see: https://stackblitz.com/edit/angular-bo4bpw?file=src/app/app.component.html I added a letter to your ids thats why it works now. BTW a new release is out |
Ok got the issue ! |
I was using collapse via Angular directive which was dynamically creating parent and child elements for collapse.
Everything was working fine until Bootstrap version 4.1.1. But after upgrading to version v4.1.2 it seems to be not working.
After going through the ship list of v4.1.1 I found that due to PR #26630 It may have stopped working.
Can anyone suggest some solution or new workaround.
Below is my table code where I am using collapse under directive of angular.
https://jsbin.com/yiqawiqone/edit?html
The text was updated successfully, but these errors were encountered: