-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of nowrap from .btn causing text in .btn within td to wrap unnecessarily #28390
Comments
You can use the |
Are you suggesting that basically every potential button on a full size app now needs checking to see if it will wrap and add the extra class to a fundamental and foundational piece of bootstrap? |
We could maybe provide a |
Potentially yea, or fix the issue that initiated this problem in a different way to begin with and not put all btn's at risk, but I feel something so foundational should not be changed as part of minor upgrade is understandable if changed in v5. |
I'm working on updating a fairly large codebase from Bootstrap 4.alpha.6 to 4.3.1, and there are hundreds and hundreds of buttons that need to be checked to see if they need this extra class. This really is quite the breaking change for it to not even get mentioned in the ship list highlights. |
Browser:
#27010 is causing button text inside td element within a .table to wrap. The issue arises because content in other columns of the table is too long causing the td element containing the button to have a reduced width resulting in the button text wrapping.
Below is an example two-row table in Bootstrap 4.1.3
and in Bootstrap 4.3.1
The JSFiddles for the above screenshots are
for 4.3.1 exhibiting the issue: https://jsfiddle.net/omairkhawaja/g2b357yo/
and for 4.1.3 without the issue: https://jsfiddle.net/omairkhawaja/ds4qcb6v/
The text was updated successfully, but these errors were encountered: