Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popper.js peer dependency moved to @popperjs/core on npm #30083

Closed
cbharris opened this issue Jan 24, 2020 · 6 comments
Closed

popper.js peer dependency moved to @popperjs/core on npm #30083

cbharris opened this issue Jan 24, 2020 · 6 comments

Comments

@cbharris
Copy link

Minor issue, but apparently the peer dependency popper.js has moved its home on npm. Relevant link here: https://www.npmjs.com/package/popper.js/v/1.16.1
Installing bootstrap forces one to install a deprecated version because of name conflicts. Can someone change the package.json to the new package name and latest version?
Many thanks.

@ryanelian
Copy link

Less than minor issue for me because the new popper JS package name apparently caused my CI to fail...

A. If I don't install the popper JS package, the CI will fail due to peerDependency warning.

B. If I install the old popper JS package, peerDependency warning disappears but the package deprecation warning appears.

@FezVrasta
Copy link
Contributor

FezVrasta commented Jan 25, 2020

There’s no reason to worry about the message, it’s there just to inform consumers of the package name change, but if one needs to use popper v1 it’s completely fine to use it.

@FezVrasta
Copy link
Contributor

I just changed the message to the following:

You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1

I hope it's going to be clearer.

@cbharris cbharris changed the title poper.js peer dependency moved to @popperjs/core on npm popper.js peer dependency moved to @popperjs/core on npm Jan 26, 2020
@cbharris
Copy link
Author

@FezVrasta, can you say if the v1 popper is actually deprecated, or will it continue to get the v2 code backported into it? If it is actually deprecated, I renew my request that this package update to v2 so we can play with the new toys like all the other cool kids.

@FezVrasta
Copy link
Contributor

I don’t plan to work on v1 anymore, but it’s not like v1 will stop work out of the blue

@XhmikosR
Copy link
Member

#29842

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants