Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong behaviour media-breakpoint-down() mixin #31118

Closed
4javier opened this issue Jun 19, 2020 · 1 comment
Closed

Wrong behaviour media-breakpoint-down() mixin #31118

4javier opened this issue Jun 19, 2020 · 1 comment

Comments

@4javier
Copy link

4javier commented Jun 19, 2020

Arch Linux
Firefox 77.0.1
Bootstrap 4.5.0

I would use this simple class to make an element disappear for viewport's width under 768px.
.my-class { @include media-breakpoint-down(md) { display: none; } }

Instead, to reach my goal I need to pass "sm" to media-breakpoint-down. Considering that I left variables untouched, I thought that media-breakpoint-down(md) should work as expected. Same thing for media-breakpoint-down(lg): it triggers at 1200px and not at 992 as the name would suggest.

I think there's inconsistency with media-breakpoint-up, where i.e. media-breakpoint-up(md) gets triggered when viewport's width reaches 768px.

@ysds
Copy link
Member

ysds commented Jun 23, 2020

This addressed in #29148 (v5). But we can't apply this change to v4 for keep compatibility.

@ysds ysds closed this as completed Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants