Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitizer strips href from even numbered links #33317

Closed
freddyheppell opened this issue Mar 9, 2021 · 3 comments
Closed

Sanitizer strips href from even numbered links #33317

freddyheppell opened this issue Mar 9, 2021 · 3 comments

Comments

@freddyheppell
Copy link

OS: macOS Big Sur 11.2.2
Browser: Firefox 86 & Chrome 88

If HTML containing multiple links is passed to the sanitizer (e.g. via creation of a Popover), even numbered links will get their href stripped, but other attributes will remain

Test case: https://codepen.io/freddyheppell/pen/RwoeXOG
@alecpl
Copy link
Contributor

alecpl commented Mar 10, 2021

Confirmed. Note that the bug exists in v5 only. No issue in v4.

@alpadev
Copy link
Contributor

alpadev commented Mar 10, 2021

This is already fixed with #33136

@mdo
Copy link
Member

mdo commented Mar 13, 2021

Closing per above comment.

@mdo mdo closed this as completed Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mdo @alecpl @freddyheppell @alpadev