-
-
Notifications
You must be signed in to change notification settings - Fork 78.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template example navbar should support multiple links #33987
Comments
This is only one example of a navbar. We got a whole example section for navbars https://getbootstrap.com/docs/5.0/examples/navbars/ and a documentation too https://getbootstrap.com/docs/5.0/components/navbar/. AFAICT the examples are meant to be an inspiration and to showcase what you can do with our components, not to provide you with a complete copy & paste solution. If they don't satisfy your needs, just adapt them to your use case. |
I understand and went through the docs. However here, it works with one link but breaks with two which I think is counter-intuitive and with the new utility-based direction, one has to figure out what tweaks and additional classes to add to the mix. Feel free to close if the template cannot evolve ✌️ |
Well, the template could evolve (and will, opening a PR) since there's IMHO something to change here: this single link shouldn't be in a list item since it's the only one. However when it comes to the use of such examples, you can't expect it'll exactly fit your needs: it's only an example, tailored on a semantic basis and using the less possible HTML and CSS to accomplish what it means to. As long as you're modifying it to fit your needs, well, you're modifying it. There's not so much things we could do here since we can't predict what people will use our examples for. In this specific case, using |
@olimart Sorry, I didn't mean to be rude or anything. Just wanted to point out that this is just an example that may not fit your needs perfectly. You made a valid point to some extent, which is why this issue wasn't closed. But as you said, it's impossible to predict what needs people might have and to address them all. There is always room for improvements and we try our best to provide good solutions. Since this is an open source project, there is always the possibility of making a contribution to improving things with a PR. |
Regarding this template https://getbootstrap.com/docs/5.0/examples/dashboard/
The current code does not support multiple links.
I understand it looks good as-is but at the same it should allow for some flexibility.
The text was updated successfully, but these errors were encountered: