Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offcanvas navbar expand leaves stray overlay #35594

Closed
3 tasks done
patrickhlauke opened this issue Dec 23, 2021 · 5 comments · Fixed by #35736
Closed
3 tasks done

Offcanvas navbar expand leaves stray overlay #35594

patrickhlauke opened this issue Dec 23, 2021 · 5 comments · Fixed by #35736
Labels

Comments

@patrickhlauke
Copy link
Member

Prerequisites

Describe the issue

A follow-up from #35577 - in the same scenario (an offcanvas navbar with .navbar-expand-${breakpoint}), if the offcanvas is opened, but then the browser window is resized, the offcanvas disappears but the semi-transparent overlay remains.

/cc @florianlacreuse

Reduced test cases

https://codepen.io/florianlacreuse/pen/wvreVxN

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of Bootstrap are you using?

v5.1.3

@patrickhlauke
Copy link
Member Author

Video of the issue

offcanvas-resize-overlay.mp4

@patrickhlauke
Copy link
Member Author

Solution likely involves some kind of resize listener somewhere that toggles the proper "close the offcanvas" logic. Unless we feel it's too much of an edge case...

@GeoSot
Copy link
Member

GeoSot commented Dec 24, 2021

Note: In case of a resize listener we might want to address #33561 too

@florianlacreuse
Copy link
Contributor

Also related to #34720.

@mdo
Copy link
Member

mdo commented Apr 12, 2022

This should be fixed with the JS changes coming in #35736.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants