-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add color-scheme for dark mode #37710
Comments
We just shipped color mode support in v5.3.0. |
@mdo I think this is a valid issue and should be re-opened. Dark mode in Bootstrap 5.3 alpha doesn't currently add the colour-scheme CSS property so UI elements are not dark (see screenshots in original post) https://developer.mozilla.org/en-US/docs/Web/CSS/color-scheme |
Agreed, |
Oh, my bad! I didn't see the second image, thanks for reopening fam :). |
Do we just need to add |
It affects a few other things too, such as browser-based autofill which typically changes the background of a form input to indicate to the user that it was autofilled. Here's a quick example from the docs which autofilled on email address of mine (Edge v108 on macOS). If the CSS had specified |
Let's try a PR to add We must double-check everything in this PR:
|
See #37734. |
Prerequisites
Proposal
Bootstrap should make use of
color-scheme
to display browser elements (scrollbar, select, etc.) in dark mode as well.Motivation and context
Here's a preview of what scrollbars currently look like in the Bootstrap documentation, and what they would look like if color scheme were used.
The text was updated successfully, but these errors were encountered: