Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar/Navs now have a focus ring #37778

Closed
3 tasks done
julien-deramond opened this issue Jan 1, 2023 · 0 comments · Fixed by #37784
Closed
3 tasks done

Navbar/Navs now have a focus ring #37778

julien-deramond opened this issue Jan 1, 2023 · 0 comments · Fixed by #37784

Comments

@julien-deramond
Copy link
Member

Prerequisites

Describe the issue

#33125 introduced a new helper to handle focus rings.

Since then, we can observe a blue outline while focusing the navbar with the mouse and with the keyboard.

2023-01-01 23 29 15

2023-01-01 23 30 05

2023-01-01 23 30 16

First of all, the outline shouldn't be displayed when the focus is given via the mouse; it should remains given by the keyboard. FWIW we removed this kind of behavior from the buttons not a long time ago.

Secondly, IMO the outline doesn't have enough contrast on our docs navbar, plus the rendering (still IMO) too much differs from the focus displayed on the navbar brand logo and from the skip links.

The possibly corresponding code:

bootstrap/scss/_nav.scss

Lines 41 to 44 in 1b39d12

&:focus {
outline: 0;
box-shadow: $nav-link-focus-box-shadow;
}

Reduced test cases

Reduced tests cases:

What operating system(s) are you seeing the problem on?

Windows, macOS, Android, iOS, Linux

What browser(s) are you seeing the problem on?

Chrome, Safari, Firefox, Microsoft Edge, Opera

What version of Bootstrap are you using?

main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant