-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Placeholder component wave animation not working in Edge #38544
Comments
I think you need Autoprefixer. We use it under the hood (through PostCSS) to keep vendor prefixes up-to-date based on supported browsers (defined in |
Oooh... I thought it's somehow being used by Bootstrap npm package to postprocess bootstrap code so I don't have to integrate it (autoprefixer) at all. So it's not like there is a bug in Bootstrap and it's just problem on my end by not using Autoprefixer? Hence all Bootstrap code is without any vendor prefixes on my end? EDIT: I understand bootstrap.css is already prefixed most likely, it's just that I'm using bootstrap scss code directly. And I thought that this is prefixed "by you guys" also. |
Yeah that's right: we cannot assume our end users' browser support. Some of them might not need prefixing at all. Our docs might be too light on the topic, but it's mentioned in Browser and devices docs page and Optimize docs page. That's too light I guess – maybe something to consider in #38538, @mdo ? |
With Vite I just added the following into the vite.config.ts and it works now.
|
I haven't seen too many issues on the missing Autoprefixer, let's leave things as they are unless there's a recommendation. Happy to accept new PRs. |
Prerequisites
Describe the issue
Hi,
I'm using Bootstrap 5.2.3 in my Vite project. Installed based on Vite Getting started guide from the docs approximately a year ago.
Everything has been working great so far, except for the placeholder-wave animation.
I noticed that the mask attributes located in the
placeholder-wave
class have-webkit
prefixed variants on the docs site where the animation works for me in the same browser, but are missing on my site.As soon as I add the prefixed variants the animation starts working.
Any idea what might be wrong? Why are these prefixes not added to the bootstrap final css on my site?
It's like I'm not getting Autoprefixer sanitized Bootstrap css on my website. But I thought Bootstrap.scss I'm referencing from the Bootstrap package is already supposed to be sanitized?
Reduced test cases
v5 template:
Here it works so I'm not sure what I'm doing wrong on my site. Followed the Vite Getting started guide to bit.
What operating system(s) are you seeing the problem on?
Windows
What browser(s) are you seeing the problem on?
Microsoft Edge
What version of Bootstrap are you using?
v5.2.3
The text was updated successfully, but these errors were encountered: