Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazelify libgmp #718

Closed
nmattia opened this issue Feb 25, 2019 · 2 comments
Closed

Bazelify libgmp #718

nmattia opened this issue Feb 25, 2019 · 2 comments
Assignees

Comments

@nmattia
Copy link
Contributor

nmattia commented Feb 25, 2019

To assess whether it is worth having libgmp provided through bazel (see #704 (comment)) the following options should be investigated:

  1. Use https://github.com/robin-thomas/bazelify-gmp
  2. Have a simple, non-modular (e.g. "quick and dirty") libgmp bazel repository
@nmattia nmattia self-assigned this Feb 25, 2019
@mboes
Copy link
Member

mboes commented Feb 25, 2019

Before doing this, figure out whether this is needed at all (see #704). If the bindists want something on the system, we should let the bindist grab what it thinks it needs from the system. Overriding with our own supplied libraries may or may not be a good idea.

@mboes
Copy link
Member

mboes commented Aug 12, 2019

This can't be easily done. bazelify-gmp won't help because ghc_bindist is a workspace rule, and needs libgmp available from the configure phase (i.e. during workspace rule execution). So libgmp needs to be a workspace repo, and it needs to either be prebuilt (where?), or we build it during workspace rule execution, but then we don't get any decent caching (and no sandboxing). On balance, I think it's better to let libgmp be picked up from the system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants