Implement soft-delete #4113
Replies: 10 comments
-
Design ready whenever needed |
Beta Was this translation helpful? Give feedback.
-
Great! This issue initially referred to frontend + backend work (deleted_at field + ability to recover at any point in time). I think it's good enough to solve the solution with your design (delaying the request), so I'm not creating a new issue related to the backend work at this point, we'll probably have to handle it some day |
Beta Was this translation helpful? Give feedback.
-
Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-265 |
Beta Was this translation helpful? Give feedback.
-
Note: the hook for toasts is called useSnackBar |
Beta Was this translation helpful? Give feedback.
-
Posting it here too: |
Beta Was this translation helpful? Give feedback.
-
@FelixMalfait , it seems very interesting to me. Can i work on this? |
Beta Was this translation helpful? Give feedback.
-
@abhithory this one is more difficult than I initially thought. I wanted to do it on the frontend initially. But in the end we need a global strategy for soft-delete on all objects |
Beta Was this translation helpful? Give feedback.
-
Ok @FelixMalfait , I am interested in this and can work if you can guide me little bit |
Beta Was this translation helpful? Give feedback.
-
@Weiko I remember we discussed this one together. It would be great to write our discussion here to provide as much context as possible |
Beta Was this translation helpful? Give feedback.
-
It's a hard problem to build soft-delete well (how to cascade deletion properly, apply the scope on pg_graphql queries etc.) |
Beta Was this translation helpful? Give feedback.
-
With the current setup it's easy to inadvertently erase a lot of records by mistake.
We should show a toast that defers sending the deletion request by a few seconds.
The deletion shouldn't still happen if I move to a new page.
See prototype here: https://www.figma.com/file/xt8O9mFeLl46C5InWwoMrN/Twenty?type=design&node-id=5215-59367&mode=design&t=3yzJPjValanNrceO-4
Beta Was this translation helpful? Give feedback.
All reactions