-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt website header for tablet version #4030
Comments
Hi Félix, |
Thanks @ahmadjafari86 ahmadjafari86! |
We have a PR down the line in which we are planning to introduce screensize hook in twenty-website. So to avoid any issues I'll be sharing the file path, name and code. Please use that hook to render different pages. I'll be commit code in this PR #3984 |
Thanks @Kanav-Arora |
Hi @ahmadjafari86 |
Hey we merged the PR but it turns out useDeviceType isn't a good solution. We should use https://emotion.sh/docs/media-queries#facepaint instead - fix coming soon |
Ok the new method is finally merged - this is the best approach! #4169 |
thanks, It's done. |
We currently have two tools to build our website Twenty.com:
Example page managed by Framer: https://twenty.com/
Example page managed by NextJS: https://twenty.com/user-guide (it's ugly! and not launched. Will be redesigned soon!)
We've done a quick v1 for the header which you can see on the NextJS page.
We adapted it on mobile/desktop but not on tablet mode.
You can view how it should look on tablet mode on the framer https://twenty.com/ website.
The goal of this ticket is to copy the behavior of the Framer website on tablet and implement it on the NextJS version.
There is already some duplicated code between the mobile and desktop version. Maybe there's an opportunity to refactor and do something cleaner as we add that third display mode? Would be amazing if we find a way to reduce the amount of duplicated code
Code for NextJS website is in: https://github.com/twentyhq/twenty/tree/main/packages/twenty-website
The text was updated successfully, but these errors were encountered: