Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace useDeviceType by media queries on website #4165

Closed
FelixMalfait opened this issue Feb 23, 2024 · 1 comment · Fixed by #4169
Closed

Replace useDeviceType by media queries on website #4165

FelixMalfait opened this issue Feb 23, 2024 · 1 comment · Fixed by #4169
Labels
scope: front Issues that are affecting the frontend side only

Comments

@FelixMalfait
Copy link
Member

On the website we copied the code we had in twenty-front to adapt the site between mobile/desktop version.
But this approach doesn't work with SSR and Next.js (this ends up with the desktop version being loaded at first and then once React is loaded it switches to the mobile version).
We need to change this and use media-queries instead https://emotion.sh/docs/media-queries

@Kanav-Arora will handle this :)
@FelixMalfait FelixMalfait added type: bug scope: front Issues that are affecting the frontend side only labels Feb 23, 2024
@Kanav-Arora Kanav-Arora mentioned this issue Feb 24, 2024
Merged
@Kanav-Arora
Copy link
Contributor

Hi @FelixMalfait
Fixed

@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope: front Issues that are affecting the frontend side only
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MQ Facepaint introduced Kanav-Arora/twenty
2 participants
@FelixMalfait @Kanav-Arora