Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkedIn field doesn't parse schools correctly #4181

Closed
FelixMalfait opened this issue Feb 26, 2024 · 2 comments · Fixed by #4198
Closed

LinkedIn field doesn't parse schools correctly #4181

FelixMalfait opened this issue Feb 26, 2024 · 2 comments · Fixed by #4198
Assignees
@EltonGohJH
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only

Comments

@FelixMalfait
Copy link
Member

Got a bug report from a user today that is also selling to schools.

In that case the URL isn't https://www.linkedin.com/company/{name}/ but https://www.linkedin.com/school/{name}/

We should fix the parsing for the LinkedIn field type to parse school urls correctly.

Screenshot 2024-02-26 at 10 25 38
@FelixMalfait FelixMalfait added type: bug good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels Feb 26, 2024
@EltonGohJH
Copy link
Contributor

I am new to Twenty. Can I give this a try?

@FelixMalfait
Copy link
Member Author

@EltonGohJH yes of course! assigning you. Thanks

@EltonGohJH EltonGohJH mentioned this issue Feb 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Product development ✅ Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EltonGohJH EltonGohJH

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only
Projects
Product development ✅
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Extend regex in Linkedin Field to support LinkedIn school URL EltonGohJH/twenty
2 participants
@FelixMalfait @EltonGohJH