Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Dropdowns have too big transparency #6777

Closed
BOHEUS opened this issue Aug 28, 2024 · 9 comments
Closed

[Firefox] Dropdowns have too big transparency #6777

BOHEUS opened this issue Aug 28, 2024 · 9 comments
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: bug Something isn't working

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Aug 28, 2024

Scenario:

  1. Log in using Firefox or Librewolf
  2. Go to Settings > Appearance
  3. Select dark mode (optional but it can be also reproduced in dark mode)
  4. Click on any dropdown

Actual: Dropdowns have too big transparency
image
image

Expected: Dropdowns should have no transparency

Note: Also found one in Settings > Developers > Webhook details
image

@BOHEUS BOHEUS added the type: bug Something isn't working label Aug 28, 2024
@BOHEUS BOHEUS changed the title Dropdowns in dark mode have too big transparency Dropdowns have too big transparency Aug 28, 2024
@Bonapara
Copy link
Member

CleanShot 2024-08-29 at 11 09 01

Working fine for me, do you experience this issue somewhere else in the app @BOHEUS?

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Aug 29, 2024

I'll check and report back once I have some time @Bonapara

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Aug 29, 2024

@Bonapara I think it's more of a browser problem as I can't reproduce it on Chromium-based browsers like Chrome or Brave but it's only on Firefox, I'm changing the title to highlight the problem with specific browser

@BOHEUS BOHEUS changed the title Dropdowns have too big transparency [Firefox] Dropdowns have too big transparency Aug 29, 2024
@charlesBochet
Copy link
Member

Good catch! We are using background-blur + opacity to compute the opacity. We should double check how background-blur looks like on Firefox.

Note that on chrome we cannot have a container with background-blur having a child with background-blur itself (in this case the background blur is not applied at all), I don't know if this is also the case in Firefox. But that's why sometimes we choose to Portal the component or to add isBackgroundBlurEnabled on some components to avoid the issue.
(However, I don't think this is related)

@charlesBochet charlesBochet added good first issue Good for newcomers scope: front Issues that are affecting the frontend side only labels Sep 1, 2024
@Bonapara
Copy link
Member

Bonapara commented Oct 1, 2024

/oss.gg 150

Copy link

oss-gg bot commented Oct 1, 2024

Thanks for opening an issue! It's live on oss.gg!

@Bonapara
Copy link
Member

Bonapara commented Oct 2, 2024

@nganphan123, do you want to handle this issue into the OSS.GG hackathon context? If so, please sign up on OSS.GG and comment /assign, otherwise happy to assign it to you manually!

@PratikAwaik
Copy link

@Bonapara Looks like this issue is fixed? I don't see this issue happening on firefox.

@Bonapara
Copy link
Member

Bonapara commented Oct 4, 2024

CleanShot 2024-10-04 at 09 46 39

Closing as can't reproduce either on Firefox

@Bonapara Bonapara closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers prio: low scope: front Issues that are affecting the frontend side only size: short type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants