Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Created by" flash upon click #6807

Open
Bonapara opened this issue Aug 30, 2024 · 6 comments
Open

"Created by" flash upon click #6807

Bonapara opened this issue Aug 30, 2024 · 6 comments
Assignees
@RobertoSimonini1
Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: bug Something isn't working

Comments

@Bonapara
Copy link
Member

Current Behavior

Created by values disappear on click

CleanShot.2024-08-30.at.16.21.00.mp4

Desired Behavior

Nothing should happen on click
@Bonapara Bonapara added type: bug Something isn't working good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: minutes labels Aug 30, 2024
@RobertoSimonini1
Copy link
Contributor

@Bonapara I would like to fix this issue

@Bonapara
Copy link
Member Author

Sure @RobertoSimonini1, thanks for contributing!

@RobertoSimonini1
Copy link
Contributor

@Bonapara I couldn't reproduce the bug, I noticed it happens when I click on the header Created By and then Filter

@charlesBochet
Copy link
Member

I could reproduce, it only happens when a filter on Created By has been applied

@Patriksafar
Copy link

Find out it might be caused by RecordTableCellBaseContainer.tsx component and relevant to openTableCell function. Removing this function fixed issue for me:

https://github.com/twentyhq/twenty/blob/main/packages/twenty-front/src/modules/object-record/record-table/record-table-cell/components/RecordTableCellBaseContainer.tsx#L70

@charlesBochet
Copy link
Member

Thanks for investigating @Patriksafar, I think we should dig deeper to find the root cause here!

  1. we should not trigger openTableCell for a readOnly field
  2. why is openTableCell creating this behavior?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RobertoSimonini1 RobertoSimonini1

Labels
good first issue Good for newcomers scope: front Issues that are affecting the frontend side only size: short type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@FelixMalfait @charlesBochet @Bonapara @Patriksafar @RobertoSimonini1