Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve scrolling in the table #7515

Closed
harshit078 opened this issue Oct 8, 2024 · 44 comments · Fixed by #7731
Closed

Improve scrolling in the table #7515

harshit078 opened this issue Oct 8, 2024 · 44 comments · Fixed by #7731
Assignees

Comments

@harshit078
Copy link
Contributor

Bug Description

  • In Tables, when scrolled the animation is not smooth and always snaps to cursor to follow it instead of making a smooth transition
  • This is very noticeable in mobile and can be frustating at times as if the user wants to read the value of first column then it is quite difficult to adjust the scoll accordingly

Current Behaviour

Screen.Recording.2024-10-09.at.12.38.12.AM.mov
Screen.Recording.2024-10-09.at.12.38.32.AM.mov

Expected behavior

A smooth transition should be occupied when scrolled

@Bonapara
Copy link
Member

Bonapara commented Oct 9, 2024

/oss.gg 300

Copy link

oss-gg bot commented Oct 9, 2024

Thanks for opening an issue! It's live on oss.gg!

@01vishu
Copy link

01vishu commented Oct 9, 2024

/assign

@oss-gg oss-gg bot assigned 01vishu Oct 9, 2024
Copy link

oss-gg bot commented Oct 9, 2024

Assigned to @01vishu! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@PremPrakashCodes
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@Fahad-Dezloper
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@ydhiman20
Copy link

/assign

Copy link

oss-gg bot commented Oct 10, 2024

This issue is already assigned to another person. Please find more issues here.

@shailjayadav30
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 11, 2024

@01vishu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@Anky9972
Copy link

/assign

Copy link

oss-gg bot commented Oct 11, 2024

This issue is already assigned to another person. Please find more issues here.

@vamsi4845
Copy link

/assign

Copy link

oss-gg bot commented Oct 12, 2024

This issue is already assigned to another person. Please find more issues here.

Copy link

oss-gg bot commented Oct 13, 2024

@01vishu, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@charlesBochet
Copy link
Member

/unassign

Copy link

oss-gg bot commented Oct 13, 2024

Issue unassigned.

@yashkhokhar28
Copy link

/assign

Copy link

oss-gg bot commented Oct 14, 2024

Assigned to @yashkhokhar28! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Rajan3208
Copy link

/assign

Copy link

oss-gg bot commented Oct 14, 2024

This issue is already assigned to another person. Please find more issues here.

@yashkhokhar28 yashkhokhar28 removed their assignment Oct 15, 2024
@Khaan25
Copy link
Contributor

Khaan25 commented Oct 15, 2024

/assign

@oss-gg oss-gg bot assigned Khaan25 Oct 15, 2024
Copy link

oss-gg bot commented Oct 15, 2024

Assigned to @Khaan25! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

@Khaan25
Copy link
Contributor

Khaan25 commented Oct 15, 2024

Here's a preview of the improved smooth scrolling in the table.

2024-10-15.11-04-01.mp4

@Khaan25
Copy link
Contributor

Khaan25 commented Oct 15, 2024

@Bonapara @harshit078

@Bonapara
Copy link
Member

Thanks @Khaan25! I think the left column should not move, can you fix that?

@Khaan25
Copy link
Contributor

Khaan25 commented Oct 15, 2024

Actually, on mobile devices, it's moving because we don't want first column to have full width.

On desktop it's not moving.

@Bonapara
Copy link
Member

To clarify, I think it's fine that the cell width is reduced. What looks strange is the spacing around the checkbox, which seems to move as well.

CleanShot.2024-10-15.at.09.48.44.mp4

Only the column width should move, not the spacing inside the cell

@Khaan25
Copy link
Contributor

Khaan25 commented Oct 15, 2024

Yeah. I'm fixing that - I think it's due to position: sticky but I'll have a look

Copy link

oss-gg bot commented Oct 16, 2024

@yashkhokhar28, Just a little reminder: Please open a draft PR linking this issue within 12 hours. If we can't detect a PR in 12h, you will be unassigned automatically.

@Khaan25
Copy link
Contributor

Khaan25 commented Oct 16, 2024

Here you go: @Bonapara

2024-10-16.09-06-19.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.