Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't link Microsoft account if there is no linked Google account #8473

Open
BOHEUS opened this issue Nov 12, 2024 · 8 comments
Open

Can't link Microsoft account if there is no linked Google account #8473

BOHEUS opened this issue Nov 12, 2024 · 8 comments

Comments

@BOHEUS
Copy link
Contributor

BOHEUS commented Nov 12, 2024

Scenario:

  1. Log in
  2. Go to Settings > Accounts

Actual: If there's no Google account linked, user can't link Microsoft account as it's hidden behind the "New account" button which is visible once Google account is linked
image

Expected: There must be option to link Microsoft account if no account was linked before
image

@khuddite
Copy link
Contributor

CleanShot 2024-11-13 at 15 28 07

I am not able to reproduce the issue on my end

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Nov 13, 2024

So it's only on demo, which is weird as changes for this were done in #8044 so they should be available already. @Bonapara is Microsoft auth disabled on demo?

@BOHEUS
Copy link
Contributor Author

BOHEUS commented Nov 13, 2024

@khuddite then I guess the only thing worth changing is "Connect a Google account" label in SettingsNewAccountSection as it's outdated, not sure what should be instead

@Bonapara
Copy link
Member

Here are the updated designs:

No connected account

We want to display the two CTAs using the Navigation Card component

image

Navigation card component: https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=34845-125690&node-type=frame&t=PcKBW7G3Bj3eu6UD-11

Connected Accounts

We want to use the Settings table component.

  • We want to display a confirmation popup when the user is deleting its account:

CleanShot 2024-11-14 at 09 41 00

  • Clicking on "Add Account" should go to the next step (see below)

image

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=45808-199845&node-type=frame&t=PcKBW7G3Bj3eu6UD-11

New account

image

https://www.figma.com/design/xt8O9mFeLl46C5InWwoMrN/Twenty?node-id=34845-125624&node-type=frame&t=PcKBW7G3Bj3eu6UD-11

@Bonapara
Copy link
Member

@khuddite do you want to handle it? :)

@khuddite
Copy link
Contributor

Sure, I will give it a try

@khuddite
Copy link
Contributor

@Bonapara I am still working on this UI refresh. In the meantime, could you give me a dev mode access on Figma?
Here is my email address - khuddite@gmail.com Thanks!

@Bonapara
Copy link
Member

@khuddite Unfortunately we cannot give access mode to contributors yet :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants