fix: navigation drawer clip while making folder in favorites #8619
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Fixed navigation drawer overflow issue when creating favorite folders by adjusting input and icon padding in NavigationDrawerInput component.
- Removed default padding from
StyledTextInputin/packages/twenty-front/src/modules/ui/navigation/navigation-drawer/components/NavigationDrawerInput.tsxto prevent overflow - Added
paddingRight: theme.spacing(2)to Icon component to maintain consistent spacing - Ensures input text stays within drawer boundaries while preserving visual alignment
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
… if collapsed on adding folder from picker
| @@ -27,6 +31,7 @@ export const FavoriteFolderPickerFooter = () => { | |||
| <MenuItem | |||
| className="add-folder" | |||
| onClick={() => { | |||
| setIsNavigationDrawerExpanded(true); | |||
There was a problem hiding this comment.
@martmull How about this? I missed this earlier and added it here -- not related to the issue.
There was a problem hiding this comment.
@ehconitin nice change
You should add also a setFavoriteFolderExpanded(true) when clicking on the add folder icon on the navigationDrawer
| @@ -27,6 +31,7 @@ export const FavoriteFolderPickerFooter = () => { | |||
| <MenuItem | |||
| className="add-folder" | |||
| onClick={() => { | |||
| setIsNavigationDrawerExpanded(true); | |||
There was a problem hiding this comment.
@ehconitin nice change
You should add also a setFavoriteFolderExpanded(true) when clicking on the add folder icon on the navigationDrawer
|
Thanks @harshrajeevsingh for your contribution! |
Fixes: #8606
Reason for the issue:
The issue was caused by the padding in
TEXT_INPUT_STYLE, which was being applied to theStyledTextInputcomponent used inNavigationDrawerInput.Changes
StyledTextInputwith a value of 0.Icon. This ensures consistent spacing between the Icon and the input value, maintaining the same visual alignment as before.Screencast.from.2024-11-20.23-32-24.webm