Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logo display is broken for companies that does not have a referenced logo #9215

Open
ijreilly opened this issue Dec 23, 2024 · 0 comments
Open

Logo display is broken for companies that does not have a referenced logo #9215

ijreilly opened this issue Dec 23, 2024 · 0 comments
Assignees
@Weiko

Comments

@ijreilly
Copy link
Collaborator

ijreilly commented Dec 23, 2024 •
edited by Weiko
Loading

Context

We recently introduced logo generation during signup based on the email domain. However, if the domain does not exist or does not have a favicon, we store the wrong URL.
Image

Fix

We should probably not store the url like this and first upload it on the file storage, the upload should take care of returning undefined or not if the image can be reached
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Weiko Weiko

Labels
None yet
Projects
Product development ✅
Status: 🆕 New
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Weiko @ijreilly