Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code audit - Remove unused methods, properties, variables. Change access levels #42

Open
GoogleCodeExporter opened this issue Mar 25, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

Go through and eliminate any methods, properties and variables that aren't
being used. 

As we've made changes, we've left around methods from the old way we did
things. We need to clean these up.

Original issue reported on code.google.com by twi...@gmail.com on 1 Apr 2008 at 9:02

@GoogleCodeExporter
Copy link
Author

Also we should change access levels appropriately.

Original comment by rustyhow...@gmail.com on 4 Apr 2008 at 3:09

  • Changed title: Code audit - Remove unused methods, properties, variables. Change access levels
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Oh, and remove all commented out code.

Original comment by twi...@gmail.com on 4 Apr 2008 at 3:12

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

And set Framework and Gui classes to internal so the students cannot access 
them.

Original comment by rustyhow...@gmail.com on 9 May 2008 at 5:06

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Issue 100: Change everything in Framework to be internal instead of public. 
Everything
that we don't want the students to see should be marked internal.

Original comment by rustyhow...@gmail.com on 14 May 2008 at 6:25

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by twi...@gmail.com on 8 Aug 2008 at 6:49

  • Added labels: Milestone-Release1.0
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by twi...@gmail.com on 12 Aug 2008 at 2:36

  • Added labels: Milestone-Release_1.0
  • Removed labels: Milestone-Release1.0

@GoogleCodeExporter
Copy link
Author

I added 'internal ' to all the classes in Framework and Gui namespaces. Looked
through the code and added a missing xml comment. 

r245

Original comment by rustyhow...@gmail.com on 25 Aug 2008 at 10:22

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant