Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC Break in Twig\Node\Expression\Test\DefinedTest #4576

Open
neclimdul opened this issue Feb 12, 2025 · 1 comment
Open

BC Break in Twig\Node\Expression\Test\DefinedTest #4576

neclimdul opened this issue Feb 12, 2025 · 1 comment

Comments

@neclimdul
Copy link

The number of people this affects is probably incredibly small but there was a BC break for some classes in 3.19. For me this triggers in \Twig\Node\Expression\Test\DefinedTest

The commit in question that caused this is: b6d9dd6

By switching to ContextVariable, if NameExpression is passed by an extension then it triggers a Syntax Exception.

This might not be a bug that needs to be fixed if that's the expected behavior going forward but it might be useful to document as a Change for extension developers.
@stof
Copy link
Member

stof commented Feb 22, 2025

Can you provide an example impacted by the BC break ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@neclimdul @stof