Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor gateway crate #1378

Closed
zeylahellyer opened this issue Dec 26, 2021 · 2 comments · Fixed by #1809
Closed

Refactor gateway crate #1378

zeylahellyer opened this issue Dec 26, 2021 · 2 comments · Fixed by #1809
Assignees
Labels
c-gateway Affects the gateway crate t-refactor Refactors APIs or code.

Comments

@zeylahellyer
Copy link
Member

zeylahellyer commented Dec 26, 2021

Refactor the internals of the gateway crate to be easier to read and to increase our bread truck scenario. The goal is to refactor our internals; the API should stay the same as a result of this refactoring, but this may surface changes that may be preferable to make outside of this work. When this is done, mostly anyone should be able to read our code. This also means documenting the code and the private API. :)

@zeylahellyer zeylahellyer added c-gateway Affects the gateway crate t-refactor Refactors APIs or code. labels Dec 26, 2021
@zeylahellyer zeylahellyer added this to the Refactor & Document milestone Dec 26, 2021
@zeylahellyer zeylahellyer moved this to Todo in Go 1.0 Dec 26, 2021
@7596ff
Copy link
Contributor

7596ff commented Jul 20, 2022

Since the entire crate is refactored by #1809, I'll add it to that issue and close the component ones.

@7596ff 7596ff linked a pull request Jul 20, 2022 that will close this issue
15 tasks
@7596ff 7596ff closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
Repository owner moved this from Todo to Done in Go 1.0 Jul 20, 2022
@7596ff 7596ff reopened this Jul 20, 2022
@7596ff 7596ff closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2022
@7596ff 7596ff reopened this Jul 20, 2022
@vilgotf
Copy link
Member

vilgotf commented Sep 27, 2022

Done in next, Twilight 0.14

@vilgotf vilgotf closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-gateway Affects the gateway crate t-refactor Refactors APIs or code.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants