Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(model): Remove sequence from GatewayEventVisitor #2307

Merged
merged 1 commit into from
Jan 13, 2024
Merged

perf(model): Remove sequence from GatewayEventVisitor #2307

merged 1 commit into from
Jan 13, 2024

Conversation

Gelbpunkt
Copy link
Member

@Gelbpunkt Gelbpunkt commented Jan 13, 2024 •
edited
Loading

This field was never used or exposed and cargo check/doc on recent nightlies started complaining about it. It is however exposed on the GatewayEvent parser so it cannot be removed there and it shouldn't.

@Gelbpunkt
perf(model): Remove sequence from GatewayEventVisitor
5671620 
Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@Gelbpunkt Gelbpunkt added c-model Affects the model crate t-perf Improves performace labels Jan 13, 2024
vilgotf
vilgotf approved these changes Jan 13, 2024
View reviewed changes
Copy link
Member

@vilgotf vilgotf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This parsing code could use some optimization, but that's for another day

@Gelbpunkt Gelbpunkt merged commit cb6d47d into twilight-rs:main Jan 13, 2024
11 checks passed
@Gelbpunkt Gelbpunkt deleted the gweventvisitor-drop-seq branch January 13, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vilgotf vilgotf vilgotf approved these changes

@Erk- Erk- Erk- approved these changes

Assignees
No one assigned
Labels
c-model Affects the model crate t-perf Improves performace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gelbpunkt @Erk- @vilgotf