feat(model): Add guild field to interaction. #2383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that this adds a new partial guild since there is a issue with the name of the fields of this specific partial guild. Closes #2381
github-actions
bot
added
c-model
github-actions
bot
added
c-cache
itohatweb
reviewed
Nov 17, 2024
Comment on lines
+487
to
+495
| #[derive(Clone, Debug, Eq, PartialEq, Deserialize, Serialize, Hash)] | ||
| pub struct InteractionPartialGuild { | ||
| /// Id of the guild. | ||
| pub id: Option<Id<GuildMarker>>, | ||
| /// Enabled guild features | ||
| pub features: Option<Vec<GuildFeature>>, | ||
| pub locale: Option<String>, | ||
| } | ||
|
|
There was a problem hiding this comment.
Probably those fields are guaranteed to exist for interactions, but it's not documented and I'm not 100% sure about that. ig option is fine.
There was a problem hiding this comment.
Yeah this partial guild is strange so I will rather go the safe route. For example the guild id is sent in the interaction so maybe they will stop duplication it here.
itohatweb
approved these changes
Nov 17, 2024
AEnterprise
approved these changes
Nov 18, 2024
qpham031
pushed a commit
to qpham031/twilight
that referenced
this pull request
Nov 22, 2024
Note that this adds a new partial guild since there is a issue with the name of the fields of this specific partial guild. Closes twilight-rs#2381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this adds a new partial guild since there is a issue with
the name of the fields of this specific partial guild.
Closes #2381