fix(environments): fix deploying to production (#16)

* fix(environments): fix deploying to production

When no domain suffix is set we should deploy to production. Similarly we should handle the lookup
of the right environment which was broken til now

* fix(client): adjust message for bare enviroments

Author: dkundel

Diff for: src/api/environments.ts

@@ -66,7 +66,7 @@ export async function createEnvironmentFromSuffix(
     form: true,
     body: {
       UniqueName: uniqueName,
-      DomainSuffix: domainSuffix,
+      DomainSuffix: domainSuffix || undefined,
       // this property currently doesn't exist but for the future lets set it
       FriendlyName: `${uniqueName} Environment (Created by CLI)`,
     },
@@ -105,7 +105,9 @@ export async function getEnvironmentFromSuffix(
 ): Promise<EnvironmentResource> {
   const environments = await listEnvironments(serviceSid, client);
   let foundEnvironments = environments.filter(
-    e => e.domain_suffix === domainSuffix
+    e =>
+      e.domain_suffix === domainSuffix ||
+      (domainSuffix.length === 0 && e.domain_suffix === null)
   );
 
   let env: EnvironmentResource | undefined;

Diff for: src/client.ts

@@ -347,7 +347,9 @@ export class TwilioServerlessApiClient extends events.EventEmitter {
 
     this.emit('status-update', {
       status: DeployStatus.CONFIGURING_ENVIRONMENT,
-      message: `Configuring "${config.functionsEnv}" environment`,
+      message: `Configuring ${
+        config.functionsEnv.length === 0 ? 'bare' : `"${config.functionsEnv}"`
+      } environment`,
     });
     const environment = await createEnvironmentIfNotExists(
       config.functionsEnv,