Skip to content

fix(environments): fix deploying to production #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2019
Merged

fix(environments): fix deploying to production #16

merged 2 commits into from
Sep 9, 2019

Conversation

dkundel
Copy link
Contributor

@dkundel dkundel commented Aug 22, 2019

When no domain suffix is set we should deploy to production. Similarly we should handle the lookup
of the right environment which was broken til now

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel
fix(environments): fix deploying to production
88c716a 
When no domain suffix is set we should deploy to production. Similarly we should handle the lookup
of the right environment which was broken til now
@dkundel dkundel requested a review from philnash August 22, 2019 00:14
@dkundel dkundel mentioned this pull request Aug 22, 2019
Merged
1 task
philnash
philnash reviewed Aug 22, 2019
View reviewed changes
@dkundel dkundel merged commit 9585237 into master Sep 9, 2019
@dkundel dkundel deleted the fix-production-deployments branch September 9, 2019 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philnash philnash philnash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkundel @philnash