-
Notifications
You must be signed in to change notification settings - Fork 11
feat(logs): add logs fetching and streaming #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes reset-dependencies npm script and adds a watch script for continuous compilation.
Should pass a client to LogsStream instead of credentials, as that's how everything else works. Access through the client should set the client. Also, changed how filtering old logs out on subsequent polls works to contain memory.
Adds StartDate, EndDate amd PageToken as options to listOnePageLogResources.
so that twilio-run can get a single page of recent logs
1 task
dkundel
suggested changes
Feb 12, 2020
This saves serializing and deserializing the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial attempt at turning polling for logs into a stream.
There are some bits missing, like passing through some of the filters in the
LogsConfig
. I can add them, I just wanted someone else to take a look at this and make sure I'm on the right track!Basic usage
The following will initialise a serverless API client and get a stream of the logs. It will then log every time there are new logs returned from the stream.
Let me know what you think. Companion PR for
twilio-run
coming soon too.Contributing to Twilio