DOMAIN_NAME in Twilio Functions does not include https:// #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! |
dkundel
pushed a commit
that referenced
this pull request
Aug 10, 2020
dkundel
pushed a commit
that referenced
this pull request
Aug 10, 2020
dkundel
pushed a commit
that referenced
this pull request
Aug 11, 2020
Previously, validating that the account sid looked like an account sid lead to the option being mandatory. This updates the prompt to not worry if the account sid is an empty string. It also adds a --skip-credentials option to avoid the tool prompting at all. Fixes #3.
dkundel
pushed a commit
that referenced
this pull request
Aug 11, 2020
Previously, validating that the account sid looked like an account sid lead to the option being mandatory. This updates the prompt to not worry if the account sid is an empty string. It also adds a --skip-credentials option to avoid the tool prompting at all. Fixes #3.
dkundel
pushed a commit
that referenced
this pull request
Aug 12, 2020
Previously, validating that the account sid looked like an account sid lead to the option being mandatory. This updates the prompt to not worry if the account sid is an empty string. It also adds a --skip-credentials option to avoid the tool prompting at all. Fixes #3.
dkundel
pushed a commit
that referenced
this pull request
Aug 12, 2020
* Add Keytar as a peer and dev dependency * Peer dependency not needed
dkundel
pushed a commit
that referenced
this pull request
Aug 12, 2020
* Add Keytar as a peer and dev dependency * Peer dependency not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create the following in a twilio function to see what I mean:
exports.handler = function(context, event, callback) {
callback(null, context.DOMAIN_NAME);
};