Skip to content

feat(new command): updates new to download multiple file templates #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

philnash
Copy link
Contributor

Uses the new layout of the functions-templates project to download multiple file templates into a
twilio-run project. Templates will be downloaded into the functions/{bundleName} and
assets/{bundleName} directories within the project.

This also allows for passing an empty bundleName (or filename in the twilio-run CLI parlance right
now). When empty, this adds the functions/assets directly into the functions/assets directories.
This will be used for create-twilio-function template options. The twilio-run CLI still enforces
a name.

BREAKING CHANGE: This needs the functions-templates repo to be up to date. Currently it points to
the next branch, which is up to date.

re #20

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Uses the new layout of the functions-templates project to download multiple file templates into a
twilio-run project. Templates will be downloaded into the functions/{bundleName} and
assets/{bundleName} directories within the project.

This also allows for passing an empty bundleName (or filename in the twilio-run CLI parlance right
 now). When empty, this adds the functions/assets directly into the functions/assets directories.
This will be used for `create-twilio-function` template options. The twilio-run CLI still enforces
a name.

BREAKING CHANGE: This needs the functions-templates repo to be up to date. Currently it points to
the next branch, which is up to date.

re twilio-labs#20
@philnash philnash requested a review from dkundel July 17, 2019 07:47
@philnash
Copy link
Contributor Author

Oh, speaking of the --filename argument, this name doesn't exactly make sense any more as there's a bundle of functions and assets. I've started calling it a bundle internally but wanted to get your opinion on that @dkundel. Is bundle a good name for the set of functions/assets that we download and is --bundle-name or a good name for the flag you can pass with --template when you start the command?

Copy link
Contributor

@dkundel dkundel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about namespace for it instead? Seems like the best description. It would als explain better if it doesn't exist

@dkundel dkundel merged commit a9f3fd2 into twilio-labs:next Jul 19, 2019
dkundel added a commit that referenced this pull request Aug 10, 2020
dkundel added a commit that referenced this pull request Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants