Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove push githook from publishing #454

Open
dkundel opened this issue Jan 18, 2023 · 0 comments
Open

Remove push githook from publishing #454

dkundel opened this issue Jan 18, 2023 · 0 comments

Comments

@dkundel
Copy link
Member

dkundel commented Jan 18, 2023

Right now when the publishing CI flow is done it will try to run git push to publish the new git tags but this triggers the on-push git hook that we use via Husky. Example: https://github.com/twilio-labs/serverless-toolkit/actions/runs/3953164384/jobs/6769250287

We should disable this in CI. Normally you do this by running --no-verify with git push but since git push is done by the changeset CLI we don't have direct control.

One option might be to add HUSKY=0 as environment variable to the publish step which should disable this behavior as well. https://typicode.github.io/husky/#/?id=bypass-hooks

@makserik makserik added this to the Improvements/Nice to haves milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants