fix: acceptance workflow failures fix #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onuzbee
reviewed
Apr 4, 2022
Comment on lines
+305
to
+315
| # enable on draft branch or with an isDraft flag | ||
| # - name: Draft - Perform testing on scoop installations | ||
| # env: | ||
| # GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| # run: | | ||
| # (New-Object System.Net.WebClient).DownloadFile('https://get.scoop.sh', 'scoop.ps1') | ||
| # ./scoop.ps1 -RunAsAdmin | ||
| # scoop bucket add twilio-scoop https://github.com/twilio/scoop-twilio-cli | ||
| # scoop install twiliodraft | ||
| # twilio --version | ||
| # twilio api --help |
There was a problem hiding this comment.
Do we know the reason for these failures?
There was a problem hiding this comment.
Not exactly, the times I ran it on forked repo, it worked perfectly. Could have been an intermittent issue. However, this block is commented as it's not applicable for a main branch release.
onuzbee
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DII-363
A short description of what this PR does:
Fixes the acceptance testing workflow errors from previous release.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.