date parser bug with moment 2.19.3

[dnalborczyk]

twilio: v3.11.2
nodejs: v9.5.0

twilio, or rather moment (v2.19.3), is parsing certain RFC2822 dates wrong, and leaves some dates as strings, instead of a Date object.

affected code path:

twilio-node/lib/base/deserialize.js

Line 61 in 14a85ad

return parseDate(s, 'ddd, DD MMM YYYY HH:mm:ss [+0000]');

twilio-node/lib/base/deserialize.js

Line 10 in 14a85ad

function parseDate(s, format) {

I haven't debugged which version of moment fixed the issue, but 2.20.1 seems to work.
Not sure if this is a bug in moment, or if the formatting string is wrong ('ddd, DD MMM YYYY HH:mm:ss [+0000]')

example repro:

const { startDate } = await client.calls(sid);

if startDate (and any other date for that matter) is e.g. 'Wed, 09 Aug 2017 01:13:35 +0000' as fetched with the REST API, parseDate() m.isValid() will be false, and a string will be returned, as supposed to a date object.

that makes me thinking, why is a string being returned in the first place? was that meant to be some sort of an escape hatch? and why is the API not returning an ISO date which would make matters simpler to begin with?

[childish-sambino]

Fixed by moment/moment#4227