Twilio crashed nodejs on errors 'Uncaught Exception'

[wasims1]

Issue Summary

For some design thinking beyond my understanding, someone decided to throw 'Uncaught exception' when twilio encounters an error. This is causing Nodejs apps to shutdown (and restart) when that happens which is quite impractical in production. This issue is well documented however i see no resolution so far. Here are some of the tickets and discussion about it:

#949
https://stackoverflow.com/questions/54175579/how-to-handle-twilio-errors-that-crash-nodejs

Steps to Reproduce

1. Run nodejs with twilio
2. Make a call that will produce an error such as: /Conversations/undefined/Participants
3. Your nodejs will crash and have to restart

Is there any timeline for fixing this terrible issue?

[bradleyy1012]

Yea this happens with a variety of specific api calls. Whoever designed the backend architecture for twilio should probably stop coding.

[tiwarishubham635]

Hi! One such issue was resolved by #952. Is there some other case where you are facing uncaught exceptions? Please share the code samples to help us reproduce the error. Thanks!

[NishikantS578]

"RestException [Error]: Invalid 'To' Phone Number" this error is also uncaught exceptions.

[tiwarishubham635]

Hi @NishikantS578! Can you please share your code snippet? Thanks!

[NishikantS578]

    client.messages.create({
        body: message,
        from: phone,
        to: "9234789238",
    })

Since the 'to' field does not have a valid phone number ( The phone number should include country code as well), twilio throws uncaught exception in response to that.

RestException [Error]: Invalid 'To' Phone Number:

It would be better if it did not threw uncaught exception, since that crashes server.

[tiwarishubham635]

Ohh got it. We need to catch these exceptions. I have added this to our internal backlog to be prioritized. +1s/reactions on this issue (and comments) and PRs will bump it higher up the backlog.