We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Same issue as #406
I see from v1 https://github.com/twilio/twilio-ruby/blob/6.0.2/lib/twilio-ruby/rest/lookups/v1/phone_number.rb#L53 to v2 the escaping was removed.
- @uri = "/PhoneNumbers/#{CGI.escape(@solution[:phone_number]).gsub("+", "%20")}" + @uri = "/PhoneNumbers/#{@solution[:phone_number]}"
use URI::DEFAULT_PARSER.escape just like Rails does
URI::DEFAULT_PARSER.escape
@uri = "/PhoneNumbers/#{URI::DEFAULT_PARSER.escape(@solution[:phone_number])}"
see #406
The text was updated successfully, but these errors were encountered:
Hi @bf4,
Thanks for the heads up!
This issue has been added to our internal backlog to be prioritised. Pull requests and +1s on the issue summary will help it move up the backlog.
With best regards,
Athira
Sorry, something went wrong.
No branches or pull requests
Issue Summary
Same issue as #406
I see from v1 https://github.com/twilio/twilio-ruby/blob/6.0.2/lib/twilio-ruby/rest/lookups/v1/phone_number.rb#L53 to v2 the escaping was removed.
Proposal
use
URI::DEFAULT_PARSER.escape
just like Rails doesSteps to Reproduce
see #406
Code Snippet
see #406
Exception/Log
see #406
Technical details:
The text was updated successfully, but these errors were encountered: