Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source of video doesn't change #425

Closed
artem-gorokhovskii opened this issue Feb 19, 2021 · 4 comments · Fixed by #508
Closed

Source of video doesn't change #425

artem-gorokhovskii opened this issue Feb 19, 2021 · 4 comments · Fixed by #508
Labels
bug Something isn't working

Comments

@artem-gorokhovskii
Copy link

Describe the bug
When you're changing video input with turned off camera (but permission for the camera - allow) - value in select changes, but the video is capturing from the previous device.

To Reproduce
Steps to reproduce the behavior:

  1. Open the browser in incognito
  2. Go to main page
  3. Move to the second step (with choosing devices to join)
    image
  4. Check, that camera permission is Allowed
  5. See a picture from your camera (your camera turned on)
  6. Turn off your camera (you will see a button "Start video" and crossed out the camera)
    image
  7. Open Settings -> Audio and video settings
  8. Change one video input to another and press "Done"
  9. Turn on your camera and see. You've chosen another source of your video input, but your receive picture from the first video device

Expected behavior
Camera picture is from selected device in video input.

Real behavior
Camera picture is from the first device, but we chose another video input device

Screenshots
selected video input: HP HD Camera (black screen - covered camera, it's ok):
image

turned off camera:
image

opened audio and video settings.
note, that initially we don't have video input device:
image

chosen another video input device: OBS Virtual Camera
and pressed "Done"
image

Start your video.
You will see the previous source of the video (what is incorrect, expected another video source):
image

Environment:

OS: Windows 10
Browser: Chrome Version 88.0.4324.150 (Official Build) (64-bit)
App Version: 0.2.1
Twilio-video: 2.9.0
Node.js version: 14.15.1

@artem-gorokhovskii artem-gorokhovskii added the bug Something isn't working label Feb 19, 2021
@artem-gorokhovskii artem-gorokhovskii changed the title We can't change source of video Source of video doesn't change Feb 19, 2021
@timmydoza
Copy link
Contributor

Thanks for the issue @artem-gorokhovskii!

I can confirm this issue. I think was also fixed is version 0.2.3. Can you please try this newer version and let me know if it helps?

Thanks again!

@artem-gorokhovskii
Copy link
Author

@timmydoza Thanks for your response!
Unfortunately, this problem also reproduces in 0.2.3.

@timmydoza
Copy link
Contributor

Hey @artem-gorokhovskii!

Looks like 0.2.3 only partially fixed the issue. I can confirm that there is still a bug to fix in 0.2.3. It looks like it only happens the first time a user grants permission to the application. All other times a user visits this app it seems to work ok.

I'll start working about a fix. Stay tuned!

@timmydoza
Copy link
Contributor

@artem-gorokhovskii - we just merged in a fix for this issue. Please let us know if you see anything else. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants