Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat input textbox not centered in Firefox #498

Closed
coreymaher opened this issue Apr 20, 2021 · 4 comments
Closed

Chat input textbox not centered in Firefox #498

coreymaher opened this issue Apr 20, 2021 · 4 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@coreymaher
Copy link

Describe the bug
The text in the chat input textbox is not vertically centered in Firefox like it is in Chrome and Safari.

To Reproduce
Steps to reproduce the behavior:

  1. In Firefox, join a video room and open the chat sidebar
  2. Notice the "Write a message..." placeholder text is not vertically centered
  3. Notice that text that is typed into the textbox is not vertically centered

Expected behavior
The text in the chat input textbox is centered

Screenshots
Firefox:
Firefox

Chrome:
Chrome

Safari:
Looks similar to Chrome

Environment (please complete the following information):

  • OS: OSX 10.15.7
  • Browser: Firefox 87.0 and Chrome 89.0.4389.128
  • App Version: v0.3.1
  • SDK Version: 2.13.1
  • Node.js version: 12.20.1

Additional context
N/A

@coreymaher coreymaher added the bug Something isn't working label Apr 20, 2021
@timmydoza
Copy link
Contributor

Thanks for the issue @coreymaher!

I can reproduce this issue as well. It seems that there are some issues when it comes to applying padding to a <textarea> element in firefox. Searching google seems to bring up a number of relevant issues, including some bugs on bugzilla.

I'm not sure what the solve here would be, but I can give it some attention. Since this issue only affects the appearance of this element and not its function, this issue will be a little bit of a lower priority for us. I'll add the "good first issue" tag to this issue in case anyone from the community want to submit a PR for it as well.

Thanks again!

@timmydoza timmydoza added the good first issue Good for newcomers label Apr 23, 2021
@coreymaher
Copy link
Author

Sounds reasonable to me, thanks @timmydoza!

@timmydoza
Copy link
Contributor

Hey @coreymaher - we got this one fixed and merged into master!

@coreymaher
Copy link
Author

Thanks so much @timmydoza!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants