Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some elements such as participants and video tracks are not working with Vue3 reactive #1420

Closed
4 tasks done
JshGrn opened this issue Mar 15, 2021 · 3 comments
Closed
4 tasks done
Assignees
Labels
help wanted Issues, feature requests, or enhancement we'd like help on or would receive PRs for

Comments

@JshGrn
Copy link

JshGrn commented Mar 15, 2021

  • I have verified that the issue occurs with the latest twilio-video.js release and is not marked as a known issue in the CHANGELOG.md.
  • I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • I verified that the Quickstart application works in my environment.
  • I am not sharing any Personally Identifiable Information (PII)
    or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Code to reproduce the issue:

https://codesandbox.io/s/vue-composition-api-example-forked-j5dej

Expected behavior:

To use vue's reactivity system with participants and videotracks. audiotracks and most other things work fine. Worth noting that I mainly am interested in having the participants reactive but the same error results with participants as videotrack produces.

Actual behavior:

See error on sandbox

Software versions:

  • Chrome & Firefox
  • Windows 10
  • twilio-video.js:
  • Vue 3
@JshGrn JshGrn changed the title Doesn't work with Vue3 reactive Some elements such as participants and video tracks are not working with Vue3 reactive Mar 15, 2021
@manjeshbhargav manjeshbhargav self-assigned this Mar 16, 2021
@manjeshbhargav manjeshbhargav added the help wanted Issues, feature requests, or enhancement we'd like help on or would receive PRs for label Mar 16, 2021
@manjeshbhargav
Copy link
Collaborator

Hi @JshGrn ,

Sorry for the delayed response. I'm not familiar with how Vue3 reactive works, but I will investigate more and get back to you.

Thanks,

Manjesh

@KaelWD
Copy link

KaelWD commented Mar 19, 2021

You probably need to use shallowReactive here.

vuejs/core#3024

@manjeshbhargav
Copy link
Collaborator

Thanks for the suggestion @KaelWD !

@JshGrn , I tried shallowReactive and it did indeed work! I think you can use this instead of reactive. I'll close the issue, but we can continue the conversation here if you need more clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Issues, feature requests, or enhancement we'd like help on or would receive PRs for
Projects
None yet
Development

No branches or pull requests

3 participants