Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to hatchling? #471

Closed
hynek opened this issue Jan 25, 2023 · 4 comments · Fixed by #472
Closed

Switch to hatchling? #471

hynek opened this issue Jan 25, 2023 · 4 comments · Fixed by #472

Comments

@hynek
Copy link
Member

hynek commented Jan 25, 2023

I'm currently three layers1 deep yak-shaving, but given that:

  1. pip / setuptools interaction is broken on 3.12
  2. Twisted has switched to hatchling

Would ya'll be interested to move towncrier to a static config too? Given the simplicity of our setup.py, it should be a simple switcheroo.

Footnotes

  1. I wanted to simplify our CI according to https://hynek.me/articles/why-i-like-nox/, but we have no pre-release so I wanted to add a pre-release, but just adding 3.12 to the noxfile explodes as explained in 1.

@altendky
Copy link
Member

I've never worked with hatchling, but as you say, this is a pretty simple project and it shouldn't be a big deal. No concerns from me.

What exactly is the need to switch to make pre-releases?

@hynek
Copy link
Member Author

hynek commented Jan 25, 2023

It doesn't, but I want to add the block that unpacks pre-release identifiers (~3.12...) to a normal version (3.12) and it would be pointless if there were no pre-release identifier in the matrix. :)

@adiroiban
Copy link
Member

Should be ok to switch. Thanks for looking into this.

@hynek
Copy link
Member Author

hynek commented Jan 27, 2023

ref #467 as a reminder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants