Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

template file not ignored in towncrier check #658

Closed
rogersheu opened this issue Aug 17, 2024 · 2 comments
Closed

template file not ignored in towncrier check #658

rogersheu opened this issue Aug 17, 2024 · 2 comments

Comments

@rogersheu
Copy link

I was working on a PR in pylint at pylint-dev/pylint#9868 and was encountering the error in this action, which has the line:

Error: Invalid news fragment name: _template.rst

We could theoretically just add a line to the towncrier.toml saying ignore = ["_template.rst"], but this particular file is already being assigned as the template in that toml with template = "doc/whatsnew/fragments/_template.rst", and if the template file is already being identified, it doesn't seem in the spirit of towncrier to have to add in that template path (or file name) to the ignore list.

I'm not sure exactly what changed between 23.11 and 24.7, which it seems like occurred around 2 weeks ago, but my guess is that it was working as expected beforehand and some change led it to regress.

I suspect this issue might be somewhat similar to #641, though it's also different because this implementation does not use --dir.

@rogersheu rogersheu changed the title template file not ignored in towncrier check --compare-with template file not ignored in towncrier check Aug 17, 2024
@jacobtylerwalls
Copy link

I think the update is here: #632 (comment).

@rogersheu
Copy link
Author

rogersheu commented Aug 17, 2024

I see. It looks like #639 will fix this issue, but it hasn't been included in a release cut yet.

Thanks @jacobtylerwalls !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants