Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking feedback on protoc twirp typescript plugin #93

Closed
larrymyers opened this issue Mar 27, 2018 · 3 comments
Closed

Seeking feedback on protoc twirp typescript plugin #93

larrymyers opened this issue Mar 27, 2018 · 3 comments

Comments

@larrymyers
Copy link
Contributor

I've created a protoc twirp client generator that outputs fairly simple typescript. I've already tested it out on a few personal projects and I've been happy with the amount of code I've been able to delete on the client and server.

I'm looking for feedback from the twirp team to see if it should be added to the list of codegen plugins in the twirp docs.

@spenczar this is the project I referenced in issue #84 , if you could take a few minutes to comment I'd appreciate the feedback to see if it's something that is useful for the general twirp community.

@spenczar
Copy link
Contributor

spenczar commented Apr 1, 2018

Excellent! This looks really great, yes! Please, go ahead and submit a PR to add it to the list on the README. Thanks!

@slaskis
Copy link

slaskis commented Apr 1, 2018

It looks great, nice and simple!

If anything I'd love if it was more extendable and maybe even no dependencies. If I could pass fetch as an option that would be nice, similar to how Apollo does it (so I can use isomorphic unfetch instead for instance). Also now i would have no control of retries etc without forking it. Perhaps a callback for the http request would be enough? With a clear default of what it is now

@larrymyers
Copy link
Contributor Author

@slaskis That's a really good idea. I'd like to continue to have an option that works out of the box for most people, but being able to inject in your own implementation of fetch makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants