-
Notifications
You must be signed in to change notification settings - Fork 31
extract url with parameters that end in close parenthesis #72
Comments
Thanks, @KL-7 and I changed paren handling recently because tweets often contain urls inside parens, but this definitely seems like a bug. We'll take a look at the regexes. For anyone looking at this, can quickly test behavior here: http://twitter.github.io/twitter-text-js/ |
I have a pull request on twitter-text-js waiting. I took your balanced parens method for the url and applied it to the query parameters as well. |
Linking your JS pull request: |
I don't have those environments set up, so it's difficult for me to test them locally. You'd probably be able to do it faster. I'm using a dotnet port that I ported over from the java, but I ended up using all the regexes from javascript because the java regex engine has a bunch of build in named character classes that aren't available in dotnet. |
Sounds good, thanks again! |
when extracting this url, the last parenthesis is always dropped:
http://www.alfred.com/Products/RefinedListing.aspx?q=@SKU=(98-40784,98-42565)
The text was updated successfully, but these errors were encountered: