Looks good for the most part. There are a bunch of one-offs that I would like to correct (e.g. setup vs set-up, # vs ##) but I don't want to burden you with unnecessary tedium.

This should be landed by the end of the weekend. Thanks for the work!

Finally got around to trying it out. It feels a little weird having the "Play" and "Pause" be hollow rather than filled in. Can we fill those in with white?

Also, would it be possible to upload the source files somewhere? We might consider creating an assets repo to keep it simple.

If I fill them in with white, it breaks the "template" setting for OS X. (Which only uses the alpha channel, and fills the icon in with white/grey), and they won't display properly. So we will have to use separate versions for each OS.

The icons are the same as icon.svg, icon-playing.svg, icon-paused.svg, Although I think I disabled the stroke on the latest versions.

I'll see if I can make the adjustments tomorrow.

Yea but since the icon is now orange instead of black, the issue of black on black should be resolved.

As an addendum, if anyone has an orange bar (not sure if possible), then we should definitely use a non-transparent fill as otherwise the user would see nothing =/

Sooo, I played around with the SVGs and got some white fill working. Unfortunately, it's not a great contrast with the light orange. I tried out black as well but that feels strange.

After that, I also realize that the headphones icon is not really discernable at a small size which is usually critical for good icon =/

The icon is not orange on Mac when using the "template" setting. Most menu bar icons on Mac are rendered in symbolic form (monochrome), as it's part of the design. It's rare to have an icon not render like this.

Here's how it appears on Mac OS X:

If you fill in the icon with white, it won't render properly.

It's probably a good idea to maintain two sets of icons anyway, so this can be accounted for.

Ideally, we should be creating a symbolic version of the icon for Linux that would match the menu bar as well, but I couldn't find any concrete resources on the subject.

Wow, those OS X ones look great.

With respect to Linux, I'm not sure all of the desktop environments will support telling us what color the menu bar is =/

With respect to Linux, I'm not sure all of the desktop environments will support telling us what color the menu bar is =/

I know many linux icon themes support symbolic icons, and we could symlink an svg symbolic version of the icon in (for instance) gnome-icon-theme-symbolic, but it would be up to a combination of desktop environment, and electron's NativeImage to use that icon.

It would definitely depend on finishing #2.

Could you link me to documentation on that? I only see Electron supporting templating images for OS X:

https://github.com/atom/electron/blob/v0.36.0/docs/api/native-image.md#template-image

It wouldn't be something Electron handles with the template image. It would have to be something specifically coded for Linux, using pre-made symbolic icons.

I just did some more research into it, and it doesn't look very feasible.